Consolidate morph method #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leastbad
approved these changes
Jul 21, 2022
|
Before we get too excited, I just realized I need to give |
leastbad
approved these changes
Jul 22, 2022
|
I think it’s better to be explicit for the moment. |
hopsoft
approved these changes
Jul 25, 2022
3 tasks
3 tasks
leastbad
added a commit
to leastbad/stimulus_reflex
that referenced
this pull request
Sep 14, 2022
leastbad
added a commit
that referenced
this pull request
Sep 14, 2022
* created Stimulus.app * elementToXPath supports html element * reflexes Proxy * dispatchLifecycleEvent converted to bind reflex * top level bind doesn't work with rollup * no need for finalStage concept anymore * added queued and delivered stages to templates * simplify lifecycle method signatures * removed action cable specific events * simplified callbacks module * renaming reflex body param to error * reworked client logging to operate on reflex params * extract duration and progress from log functions * pluggable transport mechanisms! * changed mode to plugin * changed forbidden reflexes to reject promise * return error string to forbidden promise * revert forbidden from reject to resolve * tweaks to support non-isolation mode * touch up comments in callback.js * added TODO comment wrt resolveLate * refactored reflex_store.js to reflexes.js, received() to process.js * server side changes to deprecate reflex_id in favor of id * client side modifications to rename reflexId to id * localReflexControllers can import Stimulus * revert #597 😞 * added lifecycle accessor to reflex instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement
Description
Apply the same logic to
morph, even if it's a page morphWhy should this be added
Another small one from a family of upcoming patches (and inspired by a pairing session), this aims to consolidate the logic around page morphs a bit to the other morph types. There's more to come - I'd like to go full OO here, but this one should come first, and seems straightforward.
Checklist
Please note that the best way to suggest changes or updates to the documentation is to join Discord and leave a note in the #docs channel. Any documentation updates posted as PRs cannot be accepted at this time. ❤️